Add xdp prefixes and move portal implementations to new directory #1438
Conversation
Moves the files from launch-context to xdp-app-launch-context because it implements the XdpAppLaunchContext class.
It is defined and used in this namespace so rename it to XdpSessionPersistenceMode.
The files implement functions in the XdpSessionPersistence namespace so rename the files accordingly.
Renames the portal-impl files to xdp-portal-impl.
Rename the Call class to XdpCall and adjust the function names accordingly.
Renames the call files to xdp-call.
Rename the Request class to XdpRequest and adjust the function names accordingly.
Renames the request files to xdp-request.
Rename the Session class to XdpSession and adjust the function names accordingly.
Renames the session files to xdp-session.
Rename the Permission enum and related functions to have an XDP prefix.
Renames the permission files to xdp-permission.
Rename the DocumentFlags enum and related functions to have an XDP prefix.
Renames the documents files to xdp-documents.
|
I know the diff looks daunting but this really just needs an ack on the decisions I've made here, namely:
|
|
Proper namespacing is important when doing shared libraries. I'm a bit less convinced e.g. The moving around and renaming files I see the point, but also there are not that many files, so it doesn't get us that much, and makes git archeology a bit more annoying. So, overall, I think the structure we have already is good enough, and this doesn't improve things enough to make it worth it. No strong opinions though. |
|
Not having a prefix means we can't use the G_DECLARE_TYPE macros which is the main motivation for me. It unlocks a bunch of other cleanups, having a proper split between private and public API etc. |
This renames a bunch of classes, enums and functions to have the XDP prefix. The portal implementations are moved into the portals subdir. Sources for helper binaries are moved to the new helpers subdir.
A lot of code movement but no functional changes.